Skip to content

eof: Remove support for EOF Creation Transaction #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

eof: Remove support for EOF Creation Transaction #1190

merged 3 commits into from
Apr 24, 2025
+111 −516

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Apr 8, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (17fe4a4) to head (0355d0d).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   94.80%   94.74%   -0.07%     
==========================================
  Files         172      172              
  Lines       19580    19335     -245     
==========================================
- Hits        18563    18318     -245     
  Misses       1017     1017
Flag Coverage Δ
eest_gmp 15.56% <12.50%> (+0.20%) ⬆️
eof_execution_spec_tests 2.58% <0.00%> (+0.03%) ⬆️
ethereum_tests 21.47% <8.95%> (+0.26%) ⬆️
ethereum_tests_silkpre 18.63% <12.50%> (+0.24%) ⬆️
execution_spec_tests 18.40% <8.95%> (+0.22%) ⬆️
unittests 92.44% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone/eof.cpp 86.21% <100.00%> (ø)
lib/evmone/eof.hpp 100.00% <ø> (ø)
lib/evmone/instructions_calls.cpp 98.38% <ø> (ø)
test/state/errors.hpp 67.24% <100.00%> (+1.16%) ⬆️
test/state/host.cpp 100.00% <100.00%> (ø)
test/state/state.cpp 99.07% <100.00%> (ø)
test/statetest/statetest_export.cpp 47.45% <100.00%> (+1.84%) ⬆️
test/unittests/eof_example_test.cpp 100.00% <ø> (ø)
...est/unittests/state_transition_eof_create_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_tx_test.cpp 99.08% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from 04dc99e to fa6226c Compare April 8, 2025 17:14
@gumb0 gumb0 mentioned this pull request Apr 8, 2025
Merged
@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from 5ee1029 to 3f282f4 Compare April 8, 2025 17:30
Base automatically changed from eof/txcreate to master April 9, 2025 10:59
@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from 3f282f4 to c0014e1 Compare April 9, 2025 17:15
@gumb0 gumb0 added the EOF label Apr 9, 2025
@gumb0 gumb0 marked this pull request as ready for review April 9, 2025 17:28
@gumb0 gumb0 requested review from chfast and pdobacz April 10, 2025 10:02
pdobacz
pdobacz approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from c0014e1 to 46fac88 Compare April 11, 2025 10:20
@gumb0 gumb0 marked this pull request as draft April 14, 2025 15:58
@pdobacz pdobacz force-pushed the eof/drop-eof-create-tx branch 2 times, most recently from 41a600d to d639188 Compare April 16, 2025 16:20
This was referenced Apr 22, 2025
Open
Merged
@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from d639188 to bb2568f Compare April 23, 2025 16:12
@gumb0 gumb0 marked this pull request as ready for review April 23, 2025 16:28
chfast
chfast reviewed Apr 23, 2025
View reviewed changes
@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from bb2568f to bff3549 Compare April 24, 2025 10:12
gumb0 added 3 commits April 24, 2025 12:13
@gumb0
eof: Remove support for EOF Creation Transaction
169f692
@gumb0
eof: Move stray bytes check into validate_section_header()
37a2562 
This is simplification, it is more natural to check it together with the check for truncated body.
This check was earlier moved into higher-level function to allow for stray bytes in EOF Creation Transactions.
@gumb0
eof: Make validate_header() function private
0355d0d 
No need to call from EOF Creation Transaction processing anymore.
@gumb0 gumb0 force-pushed the eof/drop-eof-create-tx branch from bff3549 to 0355d0d Compare April 24, 2025 10:13
@gumb0 gumb0 enabled auto-merge April 24, 2025 10:20
@gumb0 gumb0 merged commit 96bf424 into master Apr 24, 2025
24 checks passed
@gumb0 gumb0 deleted the eof/drop-eof-create-tx branch April 24, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@pdobacz pdobacz pdobacz approved these changes

Assignees
No one assigned
Labels
EOF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @chfast @pdobacz